-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1828 - Remove code due to hard fork - Dec 2024 #1930
base: master
Are you sure you want to change the base?
Conversation
I'm sure you already know this, but CI is now failing with:
|
Test.Cardano.Db.Mock.Unit.Babbage.Rollback | ||
Test.Cardano.Db.Mock.Unit.Babbage.Simple | ||
Test.Cardano.Db.Mock.Unit.Babbage.Stake | ||
Test.Cardano.Db.Mock.Unit.Babbage.Tx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure we want to remove ALL past era tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could keep some tests as a reference and some that showcase differences in the behaviour between eras. We could filter them together in a meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the issues that Sean raised, this looks good to me
Description
This fixes #1828
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.